Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(development.md): Minor grammatical error #8558

Merged
merged 1 commit into from
Aug 3, 2023
Merged

docs(development.md): Minor grammatical error #8558

merged 1 commit into from
Aug 3, 2023

Conversation

PauloGoncalvesLima
Copy link
Contributor

(docs) Using Docker Images During Development: Minor grammatical error

It is missing an L

image

Proposed changes

image

Location

https://datahubproject.io/docs/docker/development/

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the docs Issues and Improvements to docs label Aug 3, 2023
hsheth2
hsheth2 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 3, 2023
@anshbansal anshbansal merged commit fb40c76 into datahub-project:master Aug 3, 2023
2 checks passed
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@PauloGoncalvesLima @yoonhyejin
docs(development.md): Minor grammatical error (#8558)
99f6c1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PauloGoncalvesLima @hsheth2 @anshbansal